[asterisk-bugs] [Asterisk 0015159]: [patch] MGCP Business Phone Packages patch

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15159 
====================================================================== 
Reported By:                lejmr
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15159
Category:                   Channels/chan_mgcp/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     confirmed
Target Version:             1.6.x Version Tracker
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-05-19 13:31 CDT
Last Modified:              2009-08-27 07:05 CDT
====================================================================== 
Summary:                    [patch] MGCP Business Phone Packages patch
Description: 
I am sending patch for MGCP signaling channel.
This channel implements functionality for business phones defined in RFC
3149.
There is full implementation of KY package which handles signals end
events corresponding to function keys..
Also there is full implementation of XML package.

I am new to asterisk code so please inform me about my asterisk coding
rules mistakes.

Thanks Milos
====================================================================== 

---------------------------------------------------------------------- 
 (0109724) snuffy (manager) - 2009-08-27 07:05
 https://issues.asterisk.org/view.php?id=15159#c109724 
---------------------------------------------------------------------- 
I have updated the patch a bit, pretty much ONLY CODING-GUIDELINES

Note: There are warnings and it will still fail to compile under dev-mode

chan_mgcp.c: In function 'parse_params':
chan_mgcp.c:4374: warning: passing argument 1 of 'strncpy' discards
qualifiers from pointer target type
chan_mgcp.c: In function 'rfc3149_conf_pickup':
chan_mgcp.c:5587: warning: assignment discards qualifiers from pointer
target type
make[1]: *** [chan_mgcp.o] Error 1 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-27 07:05 snuffy         Note Added: 0109724                          
======================================================================