[asterisk-bugs] [Asterisk 0014718]: [patch] relax badshell tilde test

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14718 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14718
Category:                   Core/BuildSystem
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-21 19:05 CDT
Last Modified:              2009-08-24 17:59 CDT
====================================================================== 
Summary:                    [patch] relax badshell tilde test
Description: 
The main Makefile has a target test called 'badshell' that tests if DESTDIR
does not happen to have an an-expanded tilde (~). This might be the case if
you run:

  make isntall DESTDIR=~/somewhere/

and the shell wouldn't expand it as expected due to either bugs or lack of
features in it.

However for packaging the Debian package we have, as part of the package
name, '~dfsg' and sometimes also '~rcN'. This is because '~' is a special
character for dpkg: 1.0~1 is a number smaller than 1.0 .

Thus I suggest to relax the test a bit: check for '~/' rather than simply
for '~'.
====================================================================== 

---------------------------------------------------------------------- 
 (0109553) tilghman (administrator) - 2009-08-24 17:59
 https://issues.asterisk.org/view.php?id=14718#c109553 
---------------------------------------------------------------------- 
No, as Qwell suggested, filter ensures that the ~ starts at the beginning,
whereas findstring can find a ~ anywhere within the string. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-24 17:59 tilghman       Note Added: 0109553                          
======================================================================