[asterisk-bugs] [Asterisk 0014749]: [patch] Add support for relative path to digits, letters and phonetics files in say.c

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14749 
====================================================================== 
Reported By:                nicchap
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   14749
Category:                   Addons/New Feature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Target Version:             1.6.x Version Tracker
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-25 08:44 CDT
Last Modified:              2009-08-20 16:13 CDT
====================================================================== 
Summary:                    [patch] Add support for relative path to
digits,letters and phonetics files in say.c
Description: 
We use asterisk as our IVR base and thus support multiple applications for
multiple clients. Each client have their own set of prompts and voices,
including what I call VOCAB files, or digits - letters and phonetics.
Currently Asterisk only supports these files from the language root:

ie: digits/ or fr/digits or fr/letters and so on. 

This patch enables us to have multiple recordings of these files located
in a relative directory under the required language:

ie: allison/digits , fr/isabelle/letters, en/manuel/phonetics and so on

I tried as best to avoid touching any internals and decided to use a
channel variable called VOCAB_RELATIVE_PATH to enable this feature (simply
call the dialplan Set function to enable it). If this variable exists, then
the relative path defined by it is used, otherwise it defaults to it's
usual location. If the file is not found under the relative path, it also
defaults to it's usual location.
====================================================================== 

---------------------------------------------------------------------- 
 (0109411) tilghman (administrator) - 2009-08-20 16:13
 https://issues.asterisk.org/view.php?id=14749#c109411 
---------------------------------------------------------------------- 
1) I still don't see why you're doing this in say.c.  If this would be to
be implemented at all, I'd want to see it in file.c, implemented for all
files.

2) You need to document this behavior.

3) Since it alters how file paths are generated, it should probably be
using a channel structure element to store the path (in a stringfield) and
a dialplan function (probably CHANNEL) to get/set the value. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-20 16:13 tilghman       Note Added: 0109411                          
======================================================================