[asterisk-bugs] [Asterisk 0015716]: [patch] chan_sip fails to destroy channels in INVITE when no response received

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15716 
====================================================================== 
Reported By:                dant
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15716
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-08-13 19:15 CDT
Last Modified:              2009-08-18 15:37 CDT
====================================================================== 
Summary:                    [patch] chan_sip fails to destroy channels in INVITE
when no response received
Description: 
In the event that a call is made to a device that is not responding INVITE
packets are reliably transmitted to the device, if the call is hungup the
channel lives forever. 

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015627 [patch] Asterisk runs out of sockets
====================================================================== 

---------------------------------------------------------------------- 
 (0109243) mmichelson (administrator) - 2009-08-18 15:37
 https://issues.asterisk.org/view.php?id=15716#c109243 
---------------------------------------------------------------------- 
dant: I think I get what you're saying now. Basically, we try to send the
INVITE the maximum number of times, but the INVITE doesn't actually get
removed from the list of packets on the sip_pvt. This used to be taken care
of in sip_hangup because the packets were all cleared out prior to sending
the CANCEL.

So, there are two methods for handling this. One is the way you have done
it, and the other way would be to modify retrans_pkt so that when the
packet has reached the maximum number of retries, the packet is removed
from the list of packets on the sip_pvt. Personally, I'm more in favor of
the second method since it will handle any reliably-transmitted outbound
request type and not just INVITEs. Do you agree with this, or can you see a
potential flaw in my reasoning?

falves11: I already established in my first note that I acknowledge that
the patch contributed will work. You don't seem to understand that just
because a patch will make the issue go away, that it is not necessarily the
most correct way to handle the problem. Also, please leave drama about how
an issue "ruined" your vacation elsewhere. It does not help anything at all
ever. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-18 15:37 mmichelson     Note Added: 0109243                          
======================================================================