[asterisk-bugs] [LibPRI 0015604]: [patch] Support for called_party_subaddr, currently only calling_party_subaddr is supported

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15604 
====================================================================== 
Reported By:                alecdavis
Assigned To:                rmudgett
====================================================================== 
Project:                    LibPRI
Issue ID:                   15604
Category:                   NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2009-07-28 21:51 CDT
Last Modified:              2009-08-13 17:39 CDT
====================================================================== 
Summary:                    [patch] Support for called_party_subaddr, currently
only calling_party_subaddr is supported
Description: 
Looking at q931.c it only has dump_called_party_subaddr
it's missing receive_called_party_subaddr, transmit_called_party_subaddr,
and associated pri_call changes. Maybe more...

The Telecom Specs in NZ suggests that SUB ADDRESS is always on, so doing
"desk to desk" between offices each with an asterisk box over the ISDN
should then be possible, without a whole load of DDI numbers required.

Is there any work beinging done for this?


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0001877 Useful enhancement to chan_zap would be...
====================================================================== 

---------------------------------------------------------------------- 
 (0109020) alecdavis (reporter) - 2009-08-13 17:39
 https://issues.asterisk.org/view.php?id=15604#c109020 
---------------------------------------------------------------------- 
CALLINGSUBADDR (receiving) is already supported without any of these
proposed changes, you made it better the other day for the branch releases
as CallingSubAddr is now supported for an enbloc call, not just overlap.

The full feature implementation you have outlined above will surely only
go into 1.6.3/trunk, which may also break any dialplans/installations that
are currently using CALLINGSUBADDR, unless support for the channel variable
${CALLINGSUBADDR} is left.

Unless I've missed anything, I've included the appropriate IFDEF's to make
sure that if asterisk is upgraded without libpri, that things won't break.

The existing CallingSubAddr receive support wasn't touched, only
CallingSubAddr transmit, and it's close cousin CalledSubAddr rx/tx are were
added using exactly the same methods as CallingSubAddr.

Regarding BCD support, it's currently not in the existing branch code. I
agree BCD SubAddress support is required and should be supported in the
next full major release, 1.6.3.

Re: Updating SubAddress when a transfer happens, wouldn't that be in COLP
... 1.6.3 ?

Summary:
My goal was to complete the initial basic support for Calling and Called
Subaddress in the existing branch code base, without breaking anything, and
unless I'm wrong, this has been achieved.

For trunk: Full featured SubAddress implementation is welcome. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-13 17:39 alecdavis      Note Added: 0109020                          
======================================================================