[asterisk-bugs] [Asterisk 0015654]: [patch] Missing new-message notification for urgent messages

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15654 
====================================================================== 
Reported By:                tomo1657
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15654
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.1.2 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 210394 
Request Review:              
====================================================================== 
Date Submitted:             2009-08-04 13:23 CDT
Last Modified:              2009-08-11 13:27 CDT
====================================================================== 
Summary:                    [patch] Missing new-message notification for urgent
messages
Description: 
notify_new_message() is not called when urgent, new messages are left in a
mailbox using non-IMAP file system storage.

Urgent messages are moved to the "Urgent" folder so the following
condition to check INBOX for the new message (line 5312) is always false,
and notify_new_message() is never called.

  if (ast_fileexists(fn, NULL, NULL)) {

A workaround would be to add an exception for urgent messages:

  if (ast_fileexists(fn, NULL, NULL) && !ast_strlen_zero(flag) &&
!strcmp(flag, "Urgent"))

which I have attacked a patch of.  There are other ways to approach this,
though.  (Run notify_new_message() within the urgent message section or
checking for dfn location instead of fn)
====================================================================== 

---------------------------------------------------------------------- 
 (0108913) tomo1657 (reporter) - 2009-08-11 13:27
 https://issues.asterisk.org/view.php?id=15654#c108913 
---------------------------------------------------------------------- 
Here's an updated patch (v2) that does the following:

1) notify_new_message() checks the flag argument to see if the new message
is an Urgent message.  If so, it uses "Urgent" folder for "todir" instead
of "INBOX".

2) When a message is moved to Urgent folder, the "fn" is updated to "dfn"
(Urgent folder path), and "msgnum" is updated to "x" (Message number in
Urgent folder) so that the correct attachment is sent from the Urgent
folder.

3) The comment in the section "Created an Urgent message, moving file from
%s to %s" wasn't useful because sfn and dfn weren't populated.  I moved it
down a few lines. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-11 13:27 tomo1657       Note Added: 0108913                          
======================================================================