[asterisk-bugs] [Asterisk 0015654]: [patch] Missing new-message notification for urgent messages

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15654 
====================================================================== 
Reported By:                tomo1657
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15654
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.1.2 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 210394 
Request Review:              
====================================================================== 
Date Submitted:             2009-08-04 13:23 CDT
Last Modified:              2009-08-10 15:32 CDT
====================================================================== 
Summary:                    [patch] Missing new-message notification for urgent
messages
Description: 
notify_new_message() is not called when urgent, new messages are left in a
mailbox using non-IMAP file system storage.

Urgent messages are moved to the "Urgent" folder so the following
condition to check INBOX for the new message (line 5312) is always false,
and notify_new_message() is never called.

  if (ast_fileexists(fn, NULL, NULL)) {

A workaround would be to add an exception for urgent messages:

  if (ast_fileexists(fn, NULL, NULL) && !ast_strlen_zero(flag) &&
!strcmp(flag, "Urgent"))

which I have attacked a patch of.  There are other ways to approach this,
though.  (Run notify_new_message() within the urgent message section or
checking for dfn location instead of fn)
====================================================================== 

---------------------------------------------------------------------- 
 (0108866) tomo1657 (reporter) - 2009-08-10 15:32
 https://issues.asterisk.org/view.php?id=15654#c108866 
---------------------------------------------------------------------- 
The single issue may be that notify_new_message() only counts and attaches
new messages which are in INBOX, not Urgent.  

By moving urgent messages to Urgent before notify_new_message(), the MWI
externnotify and email attachment in the function don't work.

By moving urgent messages to Urgent after notify_new_message(), the mail
count in the function will be wrong (counts the urgent message as new,
non-urgent).

In IMAP this is not an issue because new and urgent messages are both in
INBOX.  Would we need to modify notify_new_message() to be able to select
the folder the new message is in? (INBOX or Urgent) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-10 15:32 tomo1657       Note Added: 0108866                          
======================================================================