[asterisk-bugs] [Asterisk 0015677]: [patch] ringt formatting cleanup, possible bug in distintive ring

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15677 
====================================================================== 
Reported By:                alecdavis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15677
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   text
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 211197 
Request Review:              
====================================================================== 
Date Submitted:             2009-08-07 21:24 CDT
Last Modified:              2009-08-07 23:14 CDT
====================================================================== 
Summary:                    [patch] ringt formatting cleanup, possible bug in
distintive ring
Description: 
While cleaning up 'ringt' I came across indentation issue in distinctive
ring detection.

formatting changes only.

diff highlights potential issue
if (p->ringt) { /* should this be outside of DAHDI_IOMUX_READ */ 

====================================================================== 

---------------------------------------------------------------------- 
 (0108801) alecdavis (reporter) - 2009-08-07 23:14
 https://issues.asterisk.org/view.php?id=15677#c108801 
---------------------------------------------------------------------- 
After checking with chan_zap.c from 1.2 disregard the possible bug.

The ringt decrement should be within the DAHDI_IOMUX_READ section.

patch needs comment '/* should this be outside of DAHDI_IOMUX_READ */
'taken out of it, otherwise it's fine.

This patch also fixes up the indentation issue. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-07 23:14 alecdavis      Note Added: 0108801                          
======================================================================