[asterisk-bugs] [Asterisk 0015610]: T.38 re-INVITE received after T.38 already negotiated fails

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15610 
====================================================================== 
Reported By:                huangtx2009
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   15610
Category:                   Applications/app_fax
Reproducibility:            sometimes
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.1-beta4 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 209327 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-07-29 16:16 CDT
Last Modified:              2009-08-06 12:48 CDT
====================================================================== 
Summary:                    T.38 re-INVITE received after T.38 already
negotiated fails
Description: 
I used the latest asterisk1.6.1 and spandsp0.0.6pre12. I tried to send Fax
to a Fax service provider supporting SIP T.38 (They claim their Fax service
can work with many devices well).

It is seldom successful.

But it often fails. Moreover, the error is different.
Sometimes, the error is "Unexpected message received".
Sometimes, the asterisk sender responds with 488 Not acceptable here to
the Re-INVITE for T.38.
Sometimes, the error is "the HDLC carrier did not stop in a timely
manner".

I wonder it is buggy or I do not configure something correctly. Thanks a
lot.


====================================================================== 

---------------------------------------------------------------------- 
 (0108727) svnbot (reporter) - 2009-08-06 12:48
 https://issues.asterisk.org/view.php?id=15610#c108727 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 210818

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r210818 | file | 2009-08-06 12:48:14 -0500 (Thu, 06 Aug 2009) | 18 lines

Merged revisions 210817 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r210817 | file | 2009-08-06 14:47:04 -0300 (Thu, 06 Aug 2009) | 11 lines
  
  Accept additional T.38 reinvites after an initial one has been handled.
  
  Discussion of this subject has yielded that it is not actually
acceptable to change
  T.38 parameters after the initial reinvite but declining is harsh and
can cause the
  fax to fail when it may be possible to allow it to continue. This patch
changes things
  so that additional T.38 reinvites are accepted but parameter changes
ignored. This gives
  the fax a fighting chance.
  
  (closes issue https://issues.asterisk.org/view.php?id=15610)
  Reported by: huangtx2009
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=210818 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-06 12:48 svnbot         Checkin                                      
2009-08-06 12:48 svnbot         Note Added: 0108727                          
======================================================================