[asterisk-bugs] [Asterisk 0014769]: [patch] Improvements/fixes for app_fax

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14769 
====================================================================== 
Reported By:                andrew
Assigned To:                kpfleming
====================================================================== 
Project:                    Asterisk
Issue ID:                   14769
Category:                   Applications/app_fax
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 184382 
Request Review:              
====================================================================== 
Date Submitted:             2009-03-26 15:14 CDT
Last Modified:              2009-08-06 11:07 CDT
====================================================================== 
Summary:                    [patch] Improvements/fixes for app_fax
Description: 

I was working on a backport of app_fax to asterisk 1.4 branch.

It works great now, but the original code was causing errors to be logged
(a new issue as of 1.4.24, see bug id
https://issues.asterisk.org/view.php?id=14723). As I looked into the code
more I found what I think a problems/bugs. Here is a patch (for 1.6 trunk)
for my "improvements/fixes".

I'm using SPANDSP 0.0.6pre7 and testing with SIP using an external PSTN
gateway (AS5300). I can send a fax from the system to the same system
(using the PSTN), so it seems happy. I also tested with a normal fax
machine. RX works way better than TX for me.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014812 ast_read() used with incorrect ast_wait...
====================================================================== 

---------------------------------------------------------------------- 
 (0108718) svnbot (reporter) - 2009-08-06 11:07
 https://issues.asterisk.org/view.php?id=14769#c108718 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 210777

U   trunk/apps/app_fax.c
U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r210777 | kpfleming | 2009-08-06 11:07:33 -0500 (Thu, 06 Aug 2009) | 12
lines

Minor improvements to app_fax.

This patch makes some small changes to handle watchdog timeouts in a
better way,
and also uses a 'cleaner' method of including the spandsp header files.

(closes issue https://issues.asterisk.org/view.php?id=14769)
Reported by: andrew
Patches:
      app_fax-20090406.diff uploaded by andrew (license 240)
      v1-14769.patch uploaded by dimas (license 88)
Tested by: freh, deti, caspy, dimas, sgimeno, Dovid

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=210777 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-06 11:07 svnbot         Checkin                                      
2009-08-06 11:07 svnbot         Note Added: 0108718                          
======================================================================