[asterisk-bugs] [Asterisk 0014769]: [patch] Improvements/fixes for app_fax

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14769 
====================================================================== 
Reported By:                andrew
Assigned To:                kpfleming
====================================================================== 
Project:                    Asterisk
Issue ID:                   14769
Category:                   Applications/app_fax
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 184382 
Request Review:              
====================================================================== 
Date Submitted:             2009-03-26 15:14 CDT
Last Modified:              2009-08-06 10:41 CDT
====================================================================== 
Summary:                    [patch] Improvements/fixes for app_fax
Description: 

I was working on a backport of app_fax to asterisk 1.4 branch.

It works great now, but the original code was causing errors to be logged
(a new issue as of 1.4.24, see bug id
https://issues.asterisk.org/view.php?id=14723). As I looked into the code
more I found what I think a problems/bugs. Here is a patch (for 1.6 trunk)
for my "improvements/fixes".

I'm using SPANDSP 0.0.6pre7 and testing with SIP using an external PSTN
gateway (AS5300). I can send a fax from the system to the same system
(using the PSTN), so it seems happy. I also tested with a normal fax
machine. RX works way better than TX for me.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014812 ast_read() used with incorrect ast_wait...
====================================================================== 

---------------------------------------------------------------------- 
 (0108715) kpfleming (administrator) - 2009-08-06 10:41
 https://issues.asterisk.org/view.php?id=14769#c108715 
---------------------------------------------------------------------- 
For branches other than trunk, we'll only commit changes to fix actual
problems, not just to improve the layout/structure/etc. of the code. That's
why I haven't backported the app_fax changes to 1.6.0 and 1.6.1, because at
this point the poor code structure is not actually causing failures for
anyone as far as we can tell. Yes, it generates excessive console messages,
but only as DEBUG messages, which doesn't affect normal users.

It doesn't appear that there are many fixes left here to apply to trunk;
there's no need to provide an updated patch if you can just describe what
they are, I'm happy to just make the changes and get this issue closed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-06 10:41 kpfleming      Note Added: 0108715                          
======================================================================