[asterisk-bugs] [Asterisk 0015654]: [patch] Missing new-message notification for urgent messages

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15654 
====================================================================== 
Reported By:                tomo1657
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15654
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.1.2 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 210394 
Request Review:              
====================================================================== 
Date Submitted:             2009-08-04 13:23 CDT
Last Modified:              2009-08-04 14:04 CDT
====================================================================== 
Summary:                    [patch] Missing new-message notification for urgent
messages
Description: 
notify_new_message() is not called when urgent, new messages are left in a
mailbox using non-IMAP file system storage.

Urgent messages are moved to the "Urgent" folder so the following
condition to check INBOX for the new message (line 5312) is always false,
and notify_new_message() is never called.

  if (ast_fileexists(fn, NULL, NULL)) {

A workaround would be to add an exception for urgent messages:

  if (ast_fileexists(fn, NULL, NULL) && !ast_strlen_zero(flag) &&
!strcmp(flag, "Urgent"))

which I have attacked a patch of.  There are other ways to approach this,
though.  (Run notify_new_message() within the urgent message section or
checking for dfn location instead of fn)
====================================================================== 

---------------------------------------------------------------------- 
 (0108609) tomo1657 (reporter) - 2009-08-04 14:04
 https://issues.asterisk.org/view.php?id=15654#c108609 
---------------------------------------------------------------------- 
It looks like email attatchment of urgent messages do not work either
because notify_new_messages() is expecting it to be in fn/INBOX.  Zero-size
files are being attached.  DISPOSE would need to work with fn, too.

What would be the best way to approach this?

1) set fn to point to dfn location before notify
2) move to Urgent folder only after notifying (but DISPOSE wouldn't work)
3) copy to Urgent folder instead of moving, notify, DISPOSE, and then
remove the copy in INBOX 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-04 14:04 tomo1657       Note Added: 0108609                          
======================================================================