[asterisk-bugs] [Asterisk 0014491]: [patch] DTMF blips at end of recordings in __ast_play_and_record()

[Asterisk Bug Tracker]

The following issue has been CLOSED 
====================================================================== 
https://issues.asterisk.org/view.php?id=14491 
====================================================================== 
Reported By:                asbestoshead
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   14491
Category:                   Applications/General
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     closed
Target Version:             1.6.0.x Pending Blocker
Asterisk Version:           Older 1.6.0 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-02-17 10:39 CST
Last Modified:              2009-08-03 16:11 CDT
====================================================================== 
Summary:                    [patch] DTMF blips at end of recordings in
__ast_play_and_record()
Description: 
When using a channel with real in-band DTMF (e.g. Dahdi), voicemail
greetings and other recordings have remnants of the DTMF tone left at the
end. Usually it's about 5-15ms of DTMF before the Dahdi DTMF detector
kicked in, and sometimes there's an additional 5ms at the end of the tone.

The attached patch stops recording on button DOWN, not button UP; it also
trims the last 400ms from the recording in the case where it was terminated
by DTMF. I'm not 100% happy with this, but it seems to completely get rid
of noisy blips at the end of recordings a little over 50% (*) of the time,
and I haven't heard complaints about it truncating too much. I'm sort of
looking for feedback more than anything.

The patch is against 1.6.0-beta9, but it applies cleanly to 1.6.0.5.

(*) 24 out of 43 users who changed their greetings since I applied the
patch. Some of them might have retried if they heard the blip, but most
probably wouldn't notice. I didn't notice, until it was pointed out to me
-- and since then it's all I can hear :)
====================================================================== 

---------------------------------------------------------------------- 
 (0108569) jpeeler (administrator) - 2009-08-03 16:11
 https://issues.asterisk.org/view.php?id=14491#c108569 
---------------------------------------------------------------------- 
What I was saying is that the DTMF frames do not get written to the file
(technically). Timing the duration between the begin and end events would
only be useful to use against a full timing of all the audio written to the
file as far as I can tell. The full length of the file is calculated based
on the blips being written to the file as voice data, but excluding the
actual DTMF. What this means is if the terminating DTMF key is pressed for
a long duration far too much audio will be trimmed.

asbestoshead: If you can update the patch to make the trimming optional
the patch can be merged. Since you said it will be a while before you can
update the patch I'm suspending this issue for now. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-08-03 16:11 jpeeler        Note Added: 0108569                          
2009-08-03 16:11 jpeeler        Status                   assigned => closed  
======================================================================