[asterisk-bugs] [Asterisk 0014863]: [patch] Park does not say digits back to caller

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14863 
====================================================================== 
Reported By:                noahisaac
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   14863
Category:                   Features/Parking
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 187047 
Request Review:              
====================================================================== 
Date Submitted:             2009-04-08 14:19 CDT
Last Modified:              2009-04-24 14:51 CDT
====================================================================== 
Summary:                    [patch] Park does not say digits back to caller
Description: 
Hi - 

When parking with the latest SVN of the 1.6.0 branch (and the version from
at least the past few days), the number of the parking space is not played
back to the parker.

I note that on line 593, before say-digits is called that there's a check
to see if the digits should be played back.  One of the conditions is
supposed to check to see if the original channel name is not zero length. 
Currently, it looks like this:

if (peer && (ast_strlen_zero(orig_chan_name) || ...

I'm fairly certain it should be this instead:

if (peer && (!ast_strlen_zero(orig_chan_name) || ...


I'll post a patch to do this in a minute.


Thanks!
Noah

====================================================================== 

---------------------------------------------------------------------- 
 (0103761) jpeeler (administrator) - 2009-04-24 14:51
 http://bugs.digium.com/view.php?id=14863#c103761 
---------------------------------------------------------------------- 
I think the patch I just posted is a safer change. The logic to determine
whether or not to say the digits has not changed in a while. This also
makes 1.6.0 function more like 1.4 does. The later 1.6 releases work
differently. Try the patch and see if it works as expected for all your
parking scenarios. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-24 14:51 jpeeler        Note Added: 0103761                          
======================================================================