[asterisk-bugs] [Asterisk 0014727]: lock or crash after changing sip 'transport'

Tue Apr 21 15:41:42 CDT 2009

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14727 
====================================================================== 
Reported By:                pj
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14727
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 183057 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-03-23 16:59 CDT
Last Modified:              2009-04-21 15:41 CDT
====================================================================== 
Summary:                    lock or crash after changing sip 'transport'
Description: 
When I change sip transport protocol order, eg. udp,tcp -> tcp,udp and do
'sip reload' asterisk locks or crash

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013117 [patch] multiple 'transport' on peer do...
====================================================================== 

---------------------------------------------------------------------- 
 (0103562) svnbot (reporter) - 2009-04-21 15:41
 http://bugs.digium.com/view.php?id=14727#c103562 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 189773

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r189773 | dvossel | 2009-04-21 15:41:42 -0500 (Tue, 21 Apr 2009) | 17
lines

Merged revisions 189771 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r189771 | dvossel | 2009-04-21 15:28:37 -0500 (Tue, 21 Apr 2009) | 11
lines

  Fixes segfault when switching UDP to TCP in sip.conf after reload.

  If transport in sip.conf is switched from UDP to TCP, Asterisk segfaults
right after issuing a sip reload.  The problem is the socket type is
changed to TCP but the fd may still be present for UDP.  Later, when the
TCP session should be created or set using an existing one, it isn't
because the old file descriptor is still present.  Now every time transport
is changed during a sip.conf reload, the file descriptor is set to -1,
signifying it must be created or found.

  (closes issue http://bugs.digium.com/view.php?id=14727)
  Reported by: pj
  Tested by: dvossel

  Review: http://reviewboard.digium.com/r/229/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=189773 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-21 15:41 svnbot         Checkin                                      
2009-04-21 15:41 svnbot         Note Added: 0103562                          
======================================================================