[asterisk-bugs] [DAHDI-tools 0014894]: [patch] Meaningless comparisons fopen() < 0 in dahdi_monitor.c

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=14894 
====================================================================== 
Reported By:                gknispel_proformatique
Assigned To:                seanbright
====================================================================== 
Project:                    DAHDI-tools
Issue ID:                   14894
Category:                   General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             2009-04-14 11:02 CDT
Last Modified:              2009-04-21 08:44 CDT
====================================================================== 
Summary:                    [patch] Meaningless comparisons fopen() < 0 in
dahdi_monitor.c
Description: 
The result of fopen() in dahdi_monitor.c is tested with and "fopen() < 0"
construct, which makes no sens.

"fopen() == NULL" sould be done.
====================================================================== 

---------------------------------------------------------------------- 
 (0103525) svnbot (reporter) - 2009-04-21 08:44
 http://bugs.digium.com/view.php?id=14894#c103525 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 6421

U   tools/trunk/dahdi_monitor.c

------------------------------------------------------------------------
r6421 | seanbright | 2009-04-21 08:44:58 -0500 (Tue, 21 Apr 2009) | 11
lines

Correct error check for fopen() calls in dahdi_monitor.c.

dahdi_monitor.c was checking for an error calling fopen() by determining
if the
return value was less than 0.  fopen(), however, returns a FILE * and
returns
NULL on failure.

(closes issue http://bugs.digium.com/view.php?id=14894)
Reported by: gknispel_proformatique
Patches:
      dahdi_monitor_fix_check_fopen_result.patch uploaded by gknispel
(license 261)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=6421 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-21 08:44 svnbot         Note Added: 0103525                          
2009-04-21 08:44 svnbot         Status                   new => assigned     
2009-04-21 08:44 svnbot         Assigned To               => seanbright      
======================================================================