[asterisk-bugs] [Asterisk 0014452]: in "_sip_tcp_helper_thread" Buffer is filled with dirty bytes

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14452 
====================================================================== 
Reported By:                umberto71
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14452
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.6.0.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-10 10:36 CST
Last Modified:              2009-04-17 16:16 CDT
====================================================================== 
Summary:                    in "_sip_tcp_helper_thread" Buffer is filled with
dirty bytes
Description: 
I've seen with aastra phones 51i and 57i that buffer "buf" is not empty
with TLS. 
I suggest to do this patch
.....
	for (;;) {
		memset(req.data, 0, sizeof(req.data));
		memset(buf, 0, sizeof(buf));  //<<<<<<<<<<<<<<<<<<< Patch
		req.len = 0;
		req.ignore = 0;
		req.debug = 0;
.....
====================================================================== 

---------------------------------------------------------------------- 
 (0103386) vrban (reporter) - 2009-04-17 16:16
 http://bugs.digium.com/view.php?id=14452#c103386 
---------------------------------------------------------------------- 
hello, i have seen something like that with a softphone (PhonerLite) where
the TCP buffer always was filled with a blank line. Because the softphone
broadcast empty SIP dummy packages as NAT opener. 

This was very annoying, because the dummy SIP packag contents only a
single "\r\n", with the effect, that a real SIP messages was getting this
extra blank line from the dummy package because it was still in the buffer,
and so the get_header function was not capable to work proper. I my case
this was the reason the return value for the Content-Length was always 0.

Perhaps you have the same issue with the aastra phones? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-17 16:16 vrban          Note Added: 0103386                          
======================================================================