[asterisk-bugs] [Asterisk 0014913]: limitonpeers=yes vs call-limit=1 didn't work on asterisk 1.4.24

[Asterisk Bug Tracker]

The following issue has been REOPENED. 
====================================================================== 
http://bugs.digium.com/view.php?id=14913 
====================================================================== 
Reported By:                sybasesql
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14913
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.24 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-04-16 12:57 CDT
Last Modified:              2009-04-16 17:13 CDT
====================================================================== 
Summary:                    limitonpeers=yes vs call-limit=1 didn't work on
asterisk 1.4.24
Description: 
Hello,

In asterisk 1.4.24 limitonpeers=yes vs call-limit=1 didn't work.

My setup:
[xxxxxxxxxxx]
type=friend
accountcode=xxxxxxxxxxx
username=xxxxxxxxxxx
secret=xxxxxxxxxxx
host=dynamic
qualify=yes
dtmfmode=rfc2833
nat=yes
canreinvite=no
context=xxxxxxxxxxx
callerid="xxxxxxxxxxx" <xxxxxxxxxxx>
usereqphone=yes
call-limit=1
limitonpeers=yes
disallow=all
allow=alaw

Errors:
[Apr 16 21:33:21] ERROR[23739] chan_sip.c: Call from peer 'xxxxxxxxxxx'
rejected due to usage limit of 1
[Apr 16 21:33:21] NOTICE[23739] chan_sip.c: Failed to place call for user
xxxxxxxxxxx, too many calls

Dscription:
User xxxxxxxxxxx accept inbound call and immediate make outbound call
(redirect inbound) through his peer xxxxxxxxxxx, but got error "rejected
due to usage limit of 1".

====================================================================== 

---------------------------------------------------------------------- 
 (0103353) sybasesql (reporter) - 2009-04-16 17:13
 http://bugs.digium.com/view.php?id=14913#c103353 
---------------------------------------------------------------------- 
Limitonpeers changes the way we handle incoming calls for type=friend
objects.
For type=friend, we do have two different call limits, one for incoming
calls (on user) and one for outbound calls (on peer). SIP subscriptions and
device states only check peers. 
So if you have type=friend and set call-limit to 1, the SIP device is
allowed 2 calls - one inbound and one outbound.

With limitonpeers, all call counters only use the peer side and ignore the
user. This means that SIP subscriptions will notify that the CALLING device
is busy or inuse, instead of only the CALLED device. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-16 17:13 sybasesql      Note Added: 0103353                          
2009-04-16 17:13 sybasesql      Status                   closed => new       
2009-04-16 17:13 sybasesql      Resolution               no change required =>
reopened
======================================================================