[asterisk-bugs] [Asterisk 0014846]: undefined symbols - modules can't be loaded

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14846 
====================================================================== 
Reported By:                pj
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14846
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 186622 
Request Review:              
====================================================================== 
Date Submitted:             2009-04-07 10:49 CDT
Last Modified:              2009-04-10 21:42 CDT
====================================================================== 
Summary:                    undefined symbols - modules can't be loaded
Description: 
After updating from 
Asterisk SVN-branch-1.6.1-r175257
to
Asterisk SVN-branch-1.6.1-r186622
some modules can't be loaded
compiled with 
--->  Compiler Flags
[*] DONT_OPTIMIZE
[*] DEBUG_THREADS
[*] LOADABLE_MODULES
[*] DEBUG_CHANNEL_LOCKS
[*] MALLOC_DEBUG


====================================================================== 

---------------------------------------------------------------------- 
 (0103103) plack (reporter) - 2009-04-10 21:42
 http://bugs.digium.com/view.php?id=14846#c103103 
---------------------------------------------------------------------- 
Going back far enough (not sure the exact change because svn view is
down... /gripe)

--- res/res_smdi.c	(revision 122992)
+++ res/res_smdi.c	(working copy)
@@ -1265,7 +1265,7 @@
 return_error:
 	ast_module_user_remove(u);
 
-	return 0;
+	return res;
 }

If you change it from "return res" to "return 0" app_voicemail will work. 
Looks like the correct response should have been res, but because the
documentation didn't indicate why we had a "return 0", someone corrected it
and broke the voicemail app.  We are doing a "return 0" here because we
need res_smdi.so loaded even if we don't have any interfaces, just to make
things work.

The only place this is referenced in app_voicemail.c is at 3937 (188019 in
branches 1.4)

ASTOBJ_UNREF(mwi_msg, ast_smdi_mwi_message_destroy);

Will let the code warriors on this one figure this out. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-10 21:42 plack          Note Added: 0103103                          
======================================================================