[asterisk-bugs] [Asterisk 0014815]: DTMF Appears to be broken from certain sources on asterisk 1.4.24 - double digit.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14815 
====================================================================== 
Reported By:                geoff2010
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14815
Category:                   Core/RTP
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.24 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-04-02 15:38 CDT
Last Modified:              2009-04-09 09:43 CDT
====================================================================== 
Summary:                    DTMF Appears to be broken from certain sources on
asterisk 1.4.24 - double digit.
Description: 
I am having some trouble with 1.4.24.  This appears to be a regression
since 1.4.21.1 as I have just recently upgraded and started to experience
the problem.

When calling my asterisk box from a cell phone the system detects double
DTMF digits.  When calling from a landline or pure SIP device DTMF
detection works fine.  I have determined that the cell phone is sending the
RTP DTMF payload about 2x more than the other devices, but as far as I can
tell it should still be considered a single digit as per the RFC.

Attached are two TXT files of pcap exports which show the dump for a
working DTMF interaction, and one for a failure situation.

Please let me know if I can provide any further information.

Thanks,
Geoff
====================================================================== 

---------------------------------------------------------------------- 
 (0102989) geoff2010 (reporter) - 2009-04-09 09:43
 http://bugs.digium.com/view.php?id=14815#c102989 
---------------------------------------------------------------------- 
I had done a little work and corrected the issue.  I am not 100% certain
what my changes rolled back, but for my environment I have things in
working order.  I went back to a 1.21.1 version that I was running and
compared the RFC2833 handler code with the 1.4.24 version I am currently
running.  I replaced some changed lines and made one modification to
support a change in the RTP structure in 1.4.24.

Here is a pastebin for the change I made.  If someone could explain why
this fixed things... and what I potentially broke by rolling this back I
would greatly appreciate it!

http://pastebin.com/f579f2ecc

thanks,
Geoff 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-09 09:43 geoff2010      Note Added: 0102989                          
======================================================================