[asterisk-bugs] [Asterisk 0014503]: [patch] cleanup bridging from shared variables

Asterisk Bug Tracker noreply at bugs.digium.com
Wed Apr 8 16:00:40 CDT 2009


The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=14503 
====================================================================== 
Reported By:                KNK
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   14503
Category:                   Core/General
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-02-19 03:57 CST
Last Modified:              2009-04-08 16:00 CDT
====================================================================== 
Summary:                    [patch] cleanup bridging from shared variables
Description: 
Additional cleanups to the ones from http://reviewboard.digium.com/r/163 as
discussed on dev list
====================================================================== 

---------------------------------------------------------------------- 
 (0102955) svnbot (reporter) - 2009-04-08 16:00
 http://bugs.digium.com/view.php?id=14503#c102955 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 187211

U   trunk/include/asterisk/channel.h
U   trunk/main/channel.c
U   trunk/main/features.c

------------------------------------------------------------------------
r187211 | jpeeler | 2009-04-08 16:00:39 -0500 (Wed, 08 Apr 2009) | 20
lines

Add timer for features so that backup bridge config can go away

The biggest change done here was elimination of the backup_config for use
with
features. Previously, the bridging code upon detecting a feature would set
the
start time of the bridge to the start time of the feature. Then after the 
feature had either expired or timed out the start time would be reset to
the
true bridge start time from the backup_config. Now, the time differences
are
calculated with respect to the newly added feature_start_time timeval
instead.

There should be no behavior changes from the previous functionality aside
from
the bridge timing being unaffected by either valid or partial feature
matches.
Previously the timing would be increased by the length of time configured
for
featuredigittimeout, which was probably never noticed.

(closes issue http://bugs.digium.com/view.php?id=14503)
Reported by: KNK
Tested by: jpeeler

Review: http://reviewboard.digium.com/r/179/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=187211 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-08 16:00 svnbot         Note Added: 0102955                          
2009-04-08 16:00 svnbot         Status                   feedback => assigned
2009-04-08 16:00 svnbot         Status                   assigned => resolved
2009-04-08 16:00 svnbot         Resolution               open => fixed       
======================================================================




More information about the asterisk-bugs mailing list