[asterisk-bugs] [Asterisk 0014852]: [patch] prevent a segfault when use of RetryDial is incorrect

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14852 
====================================================================== 
Reported By:                junky
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   14852
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 186841 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-04-07 23:42 CDT
Last Modified:              2009-04-08 14:18 CDT
====================================================================== 
Summary:                    [patch] prevent a segfault when use of RetryDial is
incorrect
Description: 
If you put something:
exten => 144,1,RetryDial(Local/142 at default);
in ur dialplan.
(it missings few arguments before the dialargs.


(gdb) bt
http://bugs.digium.com/view.php?id=0  0x00007f2d5d9be0b0 in strchr () from
/lib/libc.so.6
http://bugs.digium.com/view.php?id=1  0x00007f2d5616f5f5 in retrydial_exec
(chan=0x1abce80, data=0x414edd40)
at app_dial.c:1875
http://bugs.digium.com/view.php?id=2  0x000000000048534c in pbx_exec
(c=0x1abce80, app=0x1a55170,
data=0x414edd40) at pbx.c:537
http://bugs.digium.com/view.php?id=3  0x0000000000488b32 in pbx_extension_helper
(c=0x1abce80, con=0x0,
context=0x1abd0d0 "default", exten=0x1abd120 "144", priority=1, label=0x0,
callerid=0x1ab8590 "", action=E_SPAWN) at pbx.c:1863
http://bugs.digium.com/view.php?id=4  0x0000000000489dd9 in ast_spawn_extension
(c=0x1abce80,
context=0x1abd0d0 "default", exten=0x1abd120 "144", priority=1,
callerid=0x1ab8590 "") at pbx.c:2320

====================================================================== 

---------------------------------------------------------------------- 
 (0102938) svnbot (reporter) - 2009-04-08 14:18
 http://bugs.digium.com/view.php?id=14852#c102938 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 187145

_U  branches/1.6.2/

------------------------------------------------------------------------
r187145 | mmichelson | 2009-04-08 14:18:58 -0500 (Wed, 08 Apr 2009) | 19
lines

Blocked revisions 187138 via svnmerge

................
  r187138 | mmichelson | 2009-04-08 14:18:10 -0500 (Wed, 08 Apr 2009) | 13
lines
  
  Blocked revisions 187135 via svnmerge
  
  ........
    r187135 | mmichelson | 2009-04-08 14:16:49 -0500 (Wed, 08 Apr 2009) |
8 lines
    
    Fix a crash due to too few arguments to RetryDial.
    
    (closes issue http://bugs.digium.com/view.php?id=14852)
    Reported by: junky
    Patches:
          retry_fix.diff uploaded by junky (license 177)
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=187145 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-08 14:18 svnbot         Checkin                                      
2009-04-08 14:18 svnbot         Note Added: 0102938                          
======================================================================