[asterisk-bugs] [Asterisk 0014631]: [patch] Ghost calls with queues and spa942 and 922

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14631 
====================================================================== 
Reported By:                latinsud
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14631
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 180641 
Request Review:              
====================================================================== 
Date Submitted:             2009-03-09 09:17 CDT
Last Modified:              2009-04-07 20:26 CDT
====================================================================== 
Summary:                    [patch] Ghost calls with queues and spa942 and 922
Description: 
I am testing a simple static queue setup and i often get ghost calls (right
after the caller hangs up before anyone has answered) on my linksys phones
(but not on x-lite).

I also get these errors:
channel.c: ast_prod: Prodding channel ... failed
chan_sip.c: handle_response: Remote host can't match request CANCEL to
call ...

To reproduce it you have to call and be placed in que, noone answers, let
the "periodic-announce" start playing and then hangup.

I see a 2 weird things happen (imho):
- Right after caller hangs, Asterisk sends an INVITE and immediately a
CANCEL. Imho it shouldn't send any of them.
- Phone returns a "481 call does not exist".
====================================================================== 

---------------------------------------------------------------------- 
 (0102883) latinsud (reporter) - 2009-04-07 20:26
 http://bugs.digium.com/view.php?id=14631#c102883 
---------------------------------------------------------------------- 
I just sumbitted a patch.

The problem was in say_periodic_announcement(). 
The logic of the function is a bit tricky and it had a bug. If play_file()
returned a negative value we were returning 0 instead of the said value. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-07 20:26 latinsud       Note Added: 0102883                          
======================================================================