[asterisk-bugs] [Asterisk 0014686]: Regression: #13867 Reject an incoming call to peer due to call limit with "603 Declined". It`s not correct.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14686 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14686
Category:                   Channels/chan_sip/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0.6 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-17 11:42 CDT
Last Modified:              2009-04-07 08:00 CDT
====================================================================== 
Summary:                    Regression: http://bugs.digium.com/view.php?id=13867
Reject an incoming call to peer due to call limit with "603 Declined". It`s not
correct.
Description: 
When the patch for http://bugs.digium.com/view.php?id=13867 got applied to the
1.6.0 branch the test that
qualifies the setting of the hangup cause seems to have got inverted, so,
in 1.4.0 (SVN 181768) we have:

3079 	res = update_call_counter(p, INC_CALL_RINGING); 
3080 	if ( res != -1 ) {
......
3103 	} else {
3104 		ast->hangupcause = AST_CAUSE_USER_BUSY;
3105 	}
3106 	return res;

In 1.6.0.6 (r178024) we have:
4300 	res = update_call_counter(p, INC_CALL_RINGING);
4301  
4302 	if (res == -1) {
4303 		return res;
4304 	} else {
4305 		ast->hangupcause = AST_CAUSE_USER_BUSY;
4306 	}
 
Note that the != has become an ==.
 


====================================================================== 

---------------------------------------------------------------------- 
 (0102827) davidw (reporter) - 2009-04-07 08:00
 http://bugs.digium.com/view.php?id=14686#c102827 
---------------------------------------------------------------------- 
I tried the obvious fix of moving the setting of hangupcause into the
correct branch and it has restored the 1.6.0 behaviour for issue
http://bugs.digium.com/view.php?id=14802. 
That doesn't mean that I have tested it for correct behaviour in relation
to the http://bugs.digium.com/view.php?id=13867 problem. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-07 08:00 davidw         Note Added: 0102827                          
======================================================================