[asterisk-bugs] [Asterisk 0014769]: [patch] Improvements/fixes for app_fax

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14769 
====================================================================== 
Reported By:                andrew
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14769
Category:                   Applications/app_fax
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 184382 
Request Review:              
====================================================================== 
Date Submitted:             2009-03-26 15:14 CDT
Last Modified:              2009-04-06 04:39 CDT
====================================================================== 
Summary:                    [patch] Improvements/fixes for app_fax
Description: 

I was working on a backport of app_fax to asterisk 1.4 branch.

It works great now, but the original code was causing errors to be logged
(a new issue as of 1.4.24, see bug id http://bugs.digium.com/view.php?id=14723).
As I looked into the code
more I found what I think a problems/bugs. Here is a patch (for 1.6 trunk)
for my "improvements/fixes".

I'm using SPANDSP 0.0.6pre7 and testing with SIP using an external PSTN
gateway (AS5300). I can send a fax from the system to the same system
(using the PSTN), so it seems happy. I also tested with a normal fax
machine. RX works way better than TX for me.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014812 ast_read() used with incorrect ast_wait...
====================================================================== 

---------------------------------------------------------------------- 
 (0102764) sgimeno (reporter) - 2009-04-06 04:39
 http://bugs.digium.com/view.php?id=14769#c102764 
---------------------------------------------------------------------- 
I have tested the patch upon asterisk 1.6.0.7 and spandsp 0.0.6pre7 with
T.38 faxing and the messages don't appear anymore but it doesn't work
correctly.

My scenario is as follows:

Asterisk tries to send messages to a PSTN fax through a Cisco MGW.
Asterisk and the Cisco MGW try to negotiate T.38 but Asterisk rejects it
with a 488 "Not acceptable here", so Cisco downgrades the call to audio,
and asterisk tries to send the fax in audio mode.

Moreover, these traces appear while negotiating the media:

[packet-per.c 1225] Not decoded yet in packet : 2057  [unknown choice
extension]
[packet-per.c 1225] Not decoded yet in packet : 2059  [unknown choice
extension]
[packet-per.c 1225] Not decoded yet in packet : 2066  [unknown choice
extension]
[packet-per.c 1225] Not decoded yet in packet : 2071  [unknown choice
extension]
[packet-per.c 1225] Not decoded yet in packet : 2073  [unknown choice
extension]
[packet-per.c 1225] Not decoded yet in packet : 2079  [unknown choice
extension]
[packet-per.c 255] Not decoded yet in packet : 2081  [10.9.3.8.1]
[packet-per.c 826] Not decoded yet in packet : 2083  [too long integer]
[packet-per.c 255] Not decoded yet in packet : 2086  [10.9.3.8.1]
[packet-per.c 826] Not decoded yet in packet : 2088  [too long integer]
[packet-per.c 255] Not decoded yet in packet : 2091  [10.9.3.8.1] 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-06 04:39 sgimeno        Note Added: 0102764                          
======================================================================