[asterisk-bugs] [Asterisk 0014769]: [patch] Improvements/fixes for app_fax

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14769 
====================================================================== 
Reported By:                andrew
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14769
Category:                   Applications/app_fax
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 184382 
Request Review:              
====================================================================== 
Date Submitted:             2009-03-26 15:14 CDT
Last Modified:              2009-04-03 19:28 CDT
====================================================================== 
Summary:                    [patch] Improvements/fixes for app_fax
Description: 

I was working on a backport of app_fax to asterisk 1.4 branch.

It works great now, but the original code was causing errors to be logged
(a new issue as of 1.4.24, see bug id http://bugs.digium.com/view.php?id=14723).
As I looked into the code
more I found what I think a problems/bugs. Here is a patch (for 1.6 trunk)
for my "improvements/fixes".

I'm using SPANDSP 0.0.6pre7 and testing with SIP using an external PSTN
gateway (AS5300). I can send a fax from the system to the same system
(using the PSTN), so it seems happy. I also tested with a normal fax
machine. RX works way better than TX for me.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014812 ast_read() used with incorrect ast_wait...
====================================================================== 

---------------------------------------------------------------------- 
 (0102729) dimas (reporter) - 2009-04-03 19:28
 http://bugs.digium.com/view.php?id=14769#c102729 
---------------------------------------------------------------------- 
1. I believe that at the time I made app_fax, the ast_read used too return
AST_FRAME_NULL without producing any warnings even when wait_for ended with
timeout. This is why the code was organized the way it was orgenized.

2. Anyway, my understanding was that I HAD TO call
t38_terminal_send_timeout periodically even if no frames were received. I
thought that it is important for SpanDSP to be called periodically in order
to update some internal state and probably call t38_tx_packet_handler
callback which sends frames to the remote side.

I still think it is true. Because of this I do not think your fix for the
T38 part is correct. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-03 19:28 dimas          Note Added: 0102729                          
======================================================================