[asterisk-bugs] [Asterisk 0013570]: [patch] Malformed registration line is copied verbatim in To and From headers

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13570 
====================================================================== 
Reported By:                putnopvut
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13570
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0-rc6 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-09-26 18:37 CDT
Last Modified:              2008-09-26 19:08 CDT
====================================================================== 
Summary:                    [patch] Malformed registration line is copied
verbatim in To and From headers
Description: 
If a register line in Asterisk is mistyped, like "register => register =>
user:password at domain/contact", then the To and From headers Asterisk sends
out will contain the (unquoted) string

"sip:register => user:password at domain/contact>"

We should check for reserved characters, print a big warning message, and
not send a REGISTER if they are present in any of the individual components
on the register line.
====================================================================== 

---------------------------------------------------------------------- 
 (0092899) putnopvut (administrator) - 2008-09-26 19:08
 http://bugs.digium.com/view.php?id=13570#c92899 
---------------------------------------------------------------------- 
13570_14.patch is a 1.4 version of the patch. I realized that 13570.patch
would print the wrong character when telling that a reserved character had
been used, so this eliminates the problem by stating in general that a
reserved character has been used.

I'm not particularly satisfied with the lack of detail in the message, but
this is a first attempt at a patch. The logic is fine, but the reporting
could be more powerful. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-09-26 19:08 putnopvut      Note Added: 0092899                          
======================================================================