[asterisk-bugs] [LibSS7 0013495]: [patch] isup timers + q.764 compatibility + new cli commands

Asterisk Bug Tracker noreply at bugs.digium.com
Tue Sep 16 14:49:07 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13495 
====================================================================== 
Reported By:                adomjan
Assigned To:                mattf
====================================================================== 
Project:                    LibSS7
Issue ID:                   13495
Category:                   New/Feature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 140434 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-09-16 12:43 CDT
Last Modified:              2008-09-16 14:49 CDT
====================================================================== 
Summary:                    [patch] isup timers + q.764 compatibility + new cli
commands
Description: 
This path introduce isup timers, + handle the abnormal situation as the
q.764 require.

not complete, isup_gra and the others have to move to call oriantated
model.

enable isup timers, put those lines after the sigchan lines(values just
example for testing):

isup_timer.t1 = 3000
isup_timer.t5 = 7000
isup_timer.t7 = 20000

isup_timer.t12 = 5000 
isup_timer.t13 = 17000
isup_timer.t14 = 5000 
isup_timer.t15 = 17000

isup_timer.t16 = 5000
isup_timer.t17 = 17000

isup_timer.t18 = 5000
isup_timer.t19 = 17000

isup_timer.t20 = 5000
isup_timer.t21 = 17000

isup_timer.t22 = 5000
isup_timer.t23 = 17000

====================================================================== 

---------------------------------------------------------------------- 
 (0092582) mattf (administrator) - 2008-09-16 14:49
 http://bugs.digium.com/view.php?id=13495#c92582 
---------------------------------------------------------------------- 
This is a *very* big patch, that I would like to review each functional
portion separately.  Can you separate each functional portion of the patch
into separate patches for me?

So far, some of this patch can go in pretty close as is (CLI commands that
aren't dependent on timers and other changes).

The timer implementation I think needs a bit of architectural work.  

The problem with all timer implementations I have seen so far is that they
expose too much of the ugliness of handling timers to the library user. I
would like to make the user of the library (chan_dahdi) not have to be
directly aware of low level timers if possible (no timer events).  See
libpri for an example for how this can be done.  This reduces complexity
for someone writing an application based on the library.  So a lot of the
timer handling code will need to be moved into isup.c instead.

Maybe put the CLI commands into separate patches, as they can be merged
without changing how the timers are done (for the most part). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-09-16 14:49 mattf          Note Added: 0092582                          
======================================================================




More information about the asterisk-bugs mailing list