[asterisk-bugs] [Asterisk 0013409]: [patch] Huge memory leak because memory of channel cdr struct is never returned

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13409 
====================================================================== 
Reported By:                tomaso
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   13409
Category:                   Core/Channels
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 137818 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-09-01 09:48 CDT
Last Modified:              2008-09-05 08:28 CDT
====================================================================== 
Summary:                    [patch] Huge memory leak because memory of channel
cdr struct is never returned
Description: 
After two days of stress testing by making lots of calls across sip and
dahdi channels the asterisk process memory reached dizzy values: VSZ=3,2GB,
RSS=1,6GB before asterisk stucked completely (even the RAM of our server
(2GB) is finite ;-) ).

Actually this problem is not a question of load, but appears for each
single call.

Using valgrind the reason for that was quickly found: The memory of the
channel cdr struct (chan->cdr) is never returned, not for sip, not for
dahdi channels, when a channel is cleared.

Reproduce:
a.f.a.p. default configuration (modules.conf, etc.)
Make lots of calls and see ps's VSZ and RSS values.

Interested in a patch ? Or is someone revise this anyway?

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013235 Memory leak in Asterisk 1.4 and Trunk
====================================================================== 

---------------------------------------------------------------------- 
 (0092098) murf (administrator) - 2008-09-05 08:28
 http://bugs.digium.com/view.php?id=13409#c92098 
---------------------------------------------------------------------- 
tomaso-- 13235 could still easily be because of this bug; falves11 noted
truthfully that in a certain situation, memory did pile up, but I
investigated, and the dialing code is not the reason.

Daniel's letter says that using detach to free the nodes is probably not
the best thing; I think I will change it to use cdr_free instead, and
completely remove any diagnostic logging from cdr_free. Daniel might have a
nice fix to cdr_detach, which I will welcome, but if he's right about
double cdr postings, I need to take action now.

As to the question about 1.4: I have personally investigated the
applicability to 1.4, and whatever problem we have in trunk/1.6.x is in 1.4
also. That's why I apply it there.

I will make the changes I described today, and if Daniel has a good patch,
we can implement that then. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-09-05 08:28 murf           Note Added: 0092098                          
======================================================================