[asterisk-bugs] [DAHDI-linux 0013763]: [patch] warnings from sparse

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13763 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13763
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2008-10-22 07:53 CDT
Last Modified:              2008-10-28 16:38 CDT
====================================================================== 
Summary:                    [patch] warnings from sparse
Description: 
sparse is a static code parser written by Linus Torvalds mainly for usage
with the kernel code. It can be found in
http://www.kernel.org/pub/software/devel/sparse/ and is packaged with some
distributions (in Debian: under non-free).

To check a kernel code with sparse, run either:

  make C=1 # test only newer code that is being compiled

or:
  
  make C=2 # test everything that can be built

The attached sparse_log is a log for building dahdi-linux r5118 with 'make
C=2'

Right now the number of warnings and errors is:

$ egrep ' (warning|error):' sparse_log | wc -l
397

Also included is a patch that demonstrates fixing some of the simpler and
more common issues ('static' and 'C99 initializor') in some of the modules.
====================================================================== 

---------------------------------------------------------------------- 
 (0094344) svnbot (reporter) - 2008-10-28 16:38
 http://bugs.digium.com/view.php?id=13763#c94344 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 5162

U   linux/trunk/drivers/dahdi/dahdi-base.c
U   linux/trunk/drivers/dahdi/dahdi_dummy.c
U   linux/trunk/drivers/dahdi/dahdi_dynamic.c
U   linux/trunk/drivers/dahdi/dahdi_dynamic_eth.c
U   linux/trunk/drivers/dahdi/dahdi_dynamic_loc.c
U   linux/trunk/drivers/dahdi/dahdi_echocan_mg2.c
U   linux/trunk/drivers/dahdi/dahdi_transcode.c
U   linux/trunk/drivers/dahdi/pciradio.c
U   linux/trunk/drivers/dahdi/tor2.c
U   linux/trunk/drivers/dahdi/voicebus.c
_U  linux/trunk/drivers/dahdi/wcb4xxp/
U   linux/trunk/drivers/dahdi/wcb4xxp/base.c
U   linux/trunk/drivers/dahdi/wcfxo.c
U   linux/trunk/drivers/dahdi/wct1xxp.c
U   linux/trunk/drivers/dahdi/wct4xxp/base.c
U   linux/trunk/drivers/dahdi/wctc4xxp/base.c
U   linux/trunk/drivers/dahdi/wctdm.c
U   linux/trunk/drivers/dahdi/wctdm24xxp/GpakApi.c
U   linux/trunk/drivers/dahdi/wctdm24xxp/GpakCust.c
U   linux/trunk/drivers/dahdi/wctdm24xxp/base.c
U   linux/trunk/drivers/dahdi/wcte11xp.c
U   linux/trunk/drivers/dahdi/wcte12xp/GpakApi.c
U   linux/trunk/drivers/dahdi/wcte12xp/base.c
U   linux/trunk/drivers/dahdi/wcte12xp/vpmadt032.c
U   linux/trunk/drivers/dahdi/wcte12xp/vpmadt032.h

------------------------------------------------------------------------
r5162 | kpfleming | 2008-10-28 16:38:05 -0500 (Tue, 28 Oct 2008) | 8 lines

fix a large number of warnings found by sparse, the kernel code sanity
checking tool. some of these fixes are non-optimal (casting 'unsigned long'
to '__user void *'), but are unavoidable in many cases. started from
tzafrir's patch, did most of the work myself.

(closes issue http://bugs.digium.com/view.php?id=13763)
Reported by: tzafrir
Patches:
      sparse_fixes_1.diff uploaded by tzafrir (license 46)


------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=5162 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-28 16:38 svnbot         Checkin                                      
2008-10-28 16:38 svnbot         Note Added: 0094344                          
======================================================================