[asterisk-bugs] [Asterisk 0013786]: DAHDI_CHECK_HOOKSTATE automatically defined when chan_dahdi is built with zaptel support

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13786 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13786
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 151905 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-26 06:15 CDT
Last Modified:              2008-10-26 09:51 CDT
====================================================================== 
Summary:                    DAHDI_CHECK_HOOKSTATE automatically defined when
chan_dahdi is built with zaptel support
Description: 
chan_dahdi.c has the following compile time option:

/*! \note
 * Define if you want to check the hook state for an FXO (FXS signalled)
interface
 * before dialing on it.  Certain FXO interfaces always think they're out
of
 * service with this method however.
 */
/* #define DAHDI_CHECK_HOOKSTATE */

Sadly, DAHDI_CHECK_HOOKSTATE is defined unconditionally in
include/asterisk/dahdi_compat.h in case you built it with zaptel support:

#define DAHDI_CHECK_HOOKSTATE ZT_CHECK_HOOKSTATE

Thus it should be made conditioned on the definition of
ZT_CHECK_HOOKSTATE, just in case someone had it in a build script.

At first glance it seems that the same applies to:

#ifdef DAHDI_EVENT_EC_DISABLED
#ifdef DAHDI_EVENT_RINGBEGIN
#ifdef DAHDI_GETCONFMUTE
#ifdef DAHDI_PRI
#ifdef DAHDI_TONEDETECT

====================================================================== 

---------------------------------------------------------------------- 
 (0094290) tzafrir (manager) - 2008-10-26 09:51
 http://bugs.digium.com/view.php?id=13786#c94290 
---------------------------------------------------------------------- 
ZT_EVENT_RINGBEGIN - defined before zaptel 1.2 . Do we really care to keep
compatibility to those old Zaptel versions?
ZT_EVENT_EC_DISABLED - from ~ Zaptel 1.2.6
ZT_CONFMUTE - way way older than ZT_EVENT_BEGIN

DAHDI_PRI - Should probably be replaced with HAVE_PRI

ZT_TONEDETECT is from 1.4.8/1.2.23 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-26 09:51 tzafrir        Note Added: 0094290                          
======================================================================