[asterisk-bugs] [Asterisk 0013786]: DAHDI_CHECK_HOOKSTATE automatically defined when chan_dahdi is built with zaptel support

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
http://bugs.digium.com/view.php?id=13786 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13786
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 151905 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-26 06:15 CDT
Last Modified:              2008-10-26 06:15 CDT
====================================================================== 
Summary:                    DAHDI_CHECK_HOOKSTATE automatically defined when
chan_dahdi is built with zaptel support
Description: 
chan_dahdi.c has the following compile time option:

/*! \note
 * Define if you want to check the hook state for an FXO (FXS signalled)
interface
 * before dialing on it.  Certain FXO interfaces always think they're out
of
 * service with this method however.
 */
/* #define DAHDI_CHECK_HOOKSTATE */

Sadly, DAHDI_CHECK_HOOKSTATE is defined unconditionally in
include/asterisk/dahdi_compat.h in case you built it with zaptel support:

#define DAHDI_CHECK_HOOKSTATE ZT_CHECK_HOOKSTATE

ZT_CHECK_HOOKSTATE was not defined anywhere (e.g. zaptel.conf).
Furthermore, this feature has not been present in previous version
(1.4.21). Hence there is really no use in the compatibility definition.

At first glance it seems that the same applies to:

#ifdef DAHDI_EVENT_EC_DISABLED
#ifdef DAHDI_EVENT_RINGBEGIN
#ifdef DAHDI_GETCONFMUTE
#ifdef DAHDI_PRI
#ifdef DAHDI_TONEDETECT

====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-26 06:15 tzafrir        SVN Branch (only for SVN checkouts, not tarball
releases) =>  1.4            
2008-10-26 06:15 tzafrir        SVN Revision (number only!) => 151905          
2008-10-26 06:15 tzafrir        Disclaimer on File?       => N/A             
======================================================================