[asterisk-bugs] [Asterisk 0013330]: [patch] DISA does not accept extensions beginning with "#"

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13330 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13330
Category:                   Applications/app_disa
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.21.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-17 22:44 CDT
Last Modified:              2008-10-23 07:05 CDT
====================================================================== 
Summary:                    [patch] DISA does not accept extensions beginning
with "#"
Description: 
As those familiar with central office and PBX dialplans in North America
know, while "#" is often used as a terminator for variable length numbers,
it has always also been accepted as an initial character.

When I recently (finally, now that Mac OS X seems to work with the latest
patches) upgraded my production PBX to 1.4, I discovered that I was unable
to dial extensions in a DISA's context which had the pattern "_#XX"

To correct this, in the check for an extension terminated by '#' (line 301
of app_disa.c), I now also check for "i>0", so that the test only succeeds
and breaks out of the loop if the '#' is not the first character.

To comply with industry standards and practice, I suggest and request this
patch become a permanent part of Asterisk.
====================================================================== 

---------------------------------------------------------------------- 
 (0094199) jcovert (reporter) - 2008-10-23 07:05
 http://bugs.digium.com/view.php?id=13330#c94199 
---------------------------------------------------------------------- 
Could we get some action on this, please?  Bug still exists in 1.6.0.1.

Since a null extension is not meaningful, and since telephony practice
clearly allows things to begin with a "#" (e.g. #xx feature codes), and
since this is a change from past behavior which breaks existing dialplans,
and since the proposed fix is both trivial, clear, and works, could we get
this committed in both the 1.4 and 1.6 branches, please?

Thanks. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-23 07:05 jcovert        Note Added: 0094199                          
======================================================================