[asterisk-bugs] [Asterisk 0013716]: [patch] Prevent false answer of channel when going off-hook

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13716 
====================================================================== 
Reported By:                alecdavis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13716
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-16 04:58 CDT
Last Modified:              2008-10-23 03:40 CDT
====================================================================== 
Summary:                    [patch] Prevent false answer of channel when going
off-hook
Description: 
With answeronpolarityswitch=no asterisk answers channel soon after dialout
has started, or perhaps just finished. Causing Ringing for the caller to
stop, then silence for a while as the call is setup, then telco ringing is
heard and call proceedes as normal.
 
With answeronpolarityswitch=yes asterisk answers channel as soon as the
line goes off-hook. The user hears a very short Ring from Asterisk, long
silence as digits are dialled out and call is setup, then finally telco
ring is heard.
This is caused in our case because the line does a polarity reversal when
going off hook.

I have modifed wctdm.c that adds polarityignore in 3 sections of the code,
strcut fxo, wctdm_voicedaa_check_hook and wctdm_hooksig.

I'll upload for your comment, but welcome any advice if there is a better
way.
====================================================================== 

---------------------------------------------------------------------- 
 (0094189) tzafrir (manager) - 2008-10-23 03:40
 http://bugs.digium.com/view.php?id=13716#c94189 
---------------------------------------------------------------------- 
I took a look at your chan_dahdi patch again. At first I thought you
completely changed the polarity handling logic. Then I realized that the
indentation was misleading and caused the patch to look larger than it is.
Attached chan_dahdi_polarity.diff which is your patch slightly
reformatted.

A patch should describe your change so have a look at it before you submit
it. Remove unnecessary changes, as they make your patch look larger (read:
scarier) than it is. As a last resort, use the option -w of diff to hide
stupid white-space changes. -p is also handy to tell in which function
exactly your changes are. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-23 03:40 tzafrir        Note Added: 0094189                          
======================================================================