[asterisk-bugs] [Asterisk 0013706]: [patch] SIP_NOTIFY message incorrectly builds address in the To: tag

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13706 
====================================================================== 
Reported By:                andrew53
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13706
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 149593 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-15 11:13 CDT
Last Modified:              2008-10-22 09:46 CDT
====================================================================== 
Summary:                    [patch] SIP_NOTIFY message incorrectly builds
address in the To: tag
Description: 
Result of strncasecmp is misinterpreted, which results in either forming
address with no "sip:" prefix, or with the prefix repeated.

If the SUBSCRIBE From: tag was user at domain, it will result in 
To: <user at domain....
If the SUBSCRIBE From: tag was sip:user at domain, it will result in
To: <sip:sip:user at domain...
====================================================================== 

---------------------------------------------------------------------- 
 (0094133) putnopvut (administrator) - 2008-10-22 09:46
 http://bugs.digium.com/view.php?id=13706#c94133 
---------------------------------------------------------------------- 
Yes, the logic is definitely backwards on that, and this patch corrects it.
Thank you for the contribution and I'll get this fix in as soon as
possible. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-22 09:46 putnopvut      Note Added: 0094133                          
======================================================================