[asterisk-bugs] [Asterisk 0013736]: [patch] Answer() doesn't when the state is Dialing

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13736 
====================================================================== 
Reported By:                smurfix
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13736
Category:                   PBX/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-18 13:40 CDT
Last Modified:              2008-10-21 20:07 CDT
====================================================================== 
Summary:                    [patch] Answer() doesn't when the state is Dialing
Description: 
When a channel is in Dialing state, Answer() now does zilch, nada, nothing.
YOu need to call Ringing() before Answer().

That's a too-easy mistake to make.

I'm attaching a patch.
====================================================================== 

---------------------------------------------------------------------- 
 (0094114) smurfix (reporter) - 2008-10-21 20:07
 http://bugs.digium.com/view.php?id=13736#c94114 
---------------------------------------------------------------------- 
That "now" was a mistake on my part, sorry.

Anyway, as far as I know, AST_STATE_DIALING is what the channel is set to
when you have a call that's not ringing yet. (There seems to be no other
state that fits this description.)

Looking closer at the code, it seems that AST_STATE_DIALING is used on
outgoing calls only, and what I actually want for incoming calls is
AST_STATE_PRERING. In that case, my patch should simply be changed
appropriately.

I don't know what chan_dahdi did or does either; I'm actually working on
an external channel (chan_lcr, the interface between Asterisk and the Linux
Call Router, which supports the new mISDN code that's in the kernel
starting with 2.6.27). I'm using DAHDI for analog cards only, which don't
have that state. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-21 20:07 smurfix        Note Added: 0094114                          
======================================================================