[asterisk-bugs] [Asterisk 0012761]: [patch] chan_sip: build_contact() does not put alternate port setting in Contact header

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12761 
====================================================================== 
Reported By:                asbestoshead
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   12761
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 118255 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-05-30 03:04 CDT
Last Modified:              2008-10-21 18:43 CDT
====================================================================== 
Summary:                    [patch] chan_sip: build_contact() does not put
alternate port setting in Contact header
Description: 
build_contact() looks at the *other* end's port to decide whether there's a
non-standard port in use. If my end has bindport=5062 but the peer has
port=5060, when I send an invite to the peer, my Contact header doesn't
have ":5062".

initreqprep() has the same problem when setting the From: header.

chan_sip in Asterisk trunk and 1.6.0-beta8 (but not 1.4.19) have this
problem.

I have a trivial patch for this against Moy's mfcr2 branch off trunk, but
I can't find the link to sign the contributor's agreement. The patch also
applies to 1.6.0beta8, although I haven't tested it there...
====================================================================== 

---------------------------------------------------------------------- 
 (0094113) svnbot (reporter) - 2008-10-21 18:43
 http://bugs.digium.com/view.php?id=12761#c94113 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 151464

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r151464 | mmichelson | 2008-10-21 18:43:54 -0500 (Tue, 21 Oct 2008) | 11
lines

Make the sip_standard_port function more granular by allowing separate
type and port arguments. This is necessary because when building our From
and Contact headers, we need to be absolutely sure that we are placing our
source port there and not the peer's source port.

(closes issue http://bugs.digium.com/view.php?id=12761)
Reported by: asbestoshead
Patches:
      patch-chan-sip-contact-port.txt uploaded by asbestoshead (license
455)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=151464 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-21 18:43 svnbot         Note Added: 0094113                          
======================================================================