[asterisk-bugs] [Asterisk 0013747]: Indications are not passed from old peer to new peer during masquerade

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13747 
====================================================================== 
Reported By:                davidw
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13747
Category:                   Core/Channels
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.0 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-20 13:04 CDT
Last Modified:              2008-10-21 17:47 CDT
====================================================================== 
Summary:                    Indications are not passed from old peer to new peer
during masquerade
Description: 
We want to transfer a channel that is already indicating (typically
ringing) to a parked channel, which we do with AMI Originate.  When we do
this, the person on the parked channel has MOH changed to silence until the
ringing channel answers, or otherwise changes indication.

It looks to me as though there may have been some attempt to support this,
but it looks like it copies the indications at the wrong end of the
masquerade.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012548 SIP channel protocol illegally reverses...
====================================================================== 

---------------------------------------------------------------------- 
 (0094105) putnopvut (administrator) - 2008-10-21 17:47
 http://bugs.digium.com/view.php?id=13747#c94105 
---------------------------------------------------------------------- 
This seems interesting, because of all the times I've looked through the
ast_do_masquerade function, I've never noticed how indications are handled.
My interpretation of the section davidw cited in the additional information
is that that piece of code doesn't look like it actually accomplishes
anything. The visible_indication from the original channel hasn't changed
(i.e. we haven't moved the clone->visible_indication over to the original),
and so that would seem to mean that the visible_indication of the original
channel should already be in the process of being indicated.

It seems to me as if the code should actually check the clone's
visible_indication and then indicate this condition to the original
channel. I can write up a quick patch in the meantime (it's just a one-line
change), but I'm not sure if that's exactly what's wanted, nor do I know if
it will work as desired. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-21 17:47 putnopvut      Note Added: 0094105                          
======================================================================