[asterisk-bugs] [Asterisk 0013736]: [patch] Answer() doesn't when the state is Dialing

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13736 
====================================================================== 
Reported By:                smurfix
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13736
Category:                   PBX/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-18 13:40 CDT
Last Modified:              2008-10-21 17:17 CDT
====================================================================== 
Summary:                    [patch] Answer() doesn't when the state is Dialing
Description: 
When a channel is in Dialing state, Answer() now does zilch, nada, nothing.
YOu need to call Ringing() before Answer().

That's a too-easy mistake to make.

I'm attaching a patch.
====================================================================== 

---------------------------------------------------------------------- 
 (0094102) putnopvut (administrator) - 2008-10-21 17:17
 http://bugs.digium.com/view.php?id=13736#c94102 
---------------------------------------------------------------------- 
It does seem relatively straightforward, and the patch is most likely
right, the problem is that since I don't know much about chan_dahdi, I
don't know what AST_STATE_DIALING actually means. Unfortunately, like most
of the time, the comment in channel.h doesn't really help since it does not
tell if the state applies to outbound or inbound channels and is otherwise
vague. I asked about it in the #asterisk-dev IRC chat as well but did not
get an answer.

blitzrage: I can either try asking about that state on IRC again or you
can assign this to someone who is more familiar with chan_dahdi since this
issue applies only to Dahdi channels. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-21 17:17 putnopvut      Note Added: 0094102                          
======================================================================