[asterisk-bugs] [DAHDI-linux 0013487]: oops at loading tor2

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13487 
====================================================================== 
Reported By:                heyuqi
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13487
Category:                   Utilities/NewFeature
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2008-09-16 05:59 CDT
Last Modified:              2008-10-16 06:17 CDT
====================================================================== 
Summary:                    oops at loading tor2
Description: 
Several users report issues with loading the tor2 module.

BUG: unable to handle kernel NULL pointer dereference at 00000000
IP: [<e08e3de6>] :tor2:tor2_probe+0x4b4/0x962

...

Call Trace:
 [<c017ca5d>] sysfs_create_link+0x85/0xc8
 [<c01f5d61>] kobject_get+0xf/0x13
 [<c01ff9fa>] pci_device_probe+0x36/0x57
 [<c024faad>] driver_probe_device+0xb5/0x126
 [<c024fbae>] __driver_attach+0x0/0x83
 [<c024fbfe>] __driver_attach+0x50/0x83
 [<c024f0ae>] bus_for_each_dev+0x34/0x56
 [<c024f948>] driver_attach+0x11/0x13
 [<c024fbae>] __driver_attach+0x0/0x83
 [<c024f76d>] bus_add_driver+0x8a/0x1a5
 [<c017c17d>] sysfs_addrm_finish+0x13/0x163
 [<c024fd95>] driver_register+0x45/0x99
 [<c01ffb90>] __pci_register_driver+0x2b/0x57
 [<e088c015>] tor2_init+0x15/0x26 [tor2]
 [<c0130477>] sys_init_module+0x1414/0x1575
 [<e089e201>] dahdi_lboname+0x0/0x14 [dahdi]
 [<c01504af>] sys_read+0x3c/0x63
 [<c01040aa>] sysenter_past_esp+0x5f/0x85
====================================================================== 

---------------------------------------------------------------------- 
 (0093817) tzafrir (manager) - 2008-10-16 06:17
 http://bugs.digium.com/view.php?id=13487#c93817 
---------------------------------------------------------------------- 
Wow, that part of tor2 looks bad indeed.

Somebody wrote a nice faults handler, and yet in case of no memory, it
just returns -ENOMEM and frees no resource. It always returns -ENODEV
regardless of the issue. Ah, and the original null pointer issue.

The patch I uploaded attempts, sadly, to handle them all instead of a
specific patch for each issue. I also changed every message that indicates
a failure of loading the module to KERN_ERR . 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-16 06:17 tzafrir        Note Added: 0093817                          
======================================================================