[asterisk-bugs] [Asterisk 0013705]: Can't use type=friend anymore in sip.conf

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13705 
====================================================================== 
Reported By:                blitzrage
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13705
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 149559 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-15 10:55 CDT
Last Modified:              2008-10-15 16:30 CDT
====================================================================== 
Summary:                    Can't use type=friend anymore in sip.conf
Description: 
Seems I can't authenticate a user in sip.conf when using type=friend. A
very simple definition in sip.conf:

[200]
type=friend
host=dynamic
context=forTesting

In the sip debug from the CLI I get:

No matching peer for '200' from '192.168.128.129:5060'


But if I change it to type=peer this works. Is this part of the "kill the
user" work? If so, shouldn't type=friend still work for backwards
compatibility?

Does this mean the type=user is also entirely gone? (haven't tested this
part yet)
====================================================================== 

---------------------------------------------------------------------- 
 (0093781) bweschke (manager) - 2008-10-15 16:30
 http://bugs.digium.com/view.php?id=13705#c93781 
---------------------------------------------------------------------- 
The code looks like it is still there on trunk in chan_sip to recognize
this. I'd need to load /trunk to try to reproduce, but doesn't make any
initial sense as to why it wouldn't be working anymore.

                utype = ast_variable_retrieve(cfg, cat, "type");
                if (!utype) {
                        ast_log(LOG_WARNING, "Section '%s' lacks type\n",
cat);
                        continue;
                } else {
                        int is_peer = 0;
                        if (!strcasecmp(utype, "user")) {
                                is_peer = 1;
                        } else if (!strcasecmp(utype, "friend")) {
                                is_peer = 1;
                        } else if (!strcasecmp(utype, "peer"))
                                is_peer = 2;
                        else {
                                ast_log(LOG_WARNING, "Unknown type '%s'
for '%s' in %s\n", utype, cat, "sip.conf");
                                continue;
                        } 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-15 16:30 bweschke       Note Added: 0093781                          
======================================================================