[asterisk-bugs] [Asterisk 0013675]: [patch] app_sms doesn't answer the call, currently requires Answer() before hand

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13675 
====================================================================== 
Reported By:                alecdavis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13675
Category:                   Applications/app_sms
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-12 15:16 CDT
Last Modified:              2008-10-15 02:00 CDT
====================================================================== 
Summary:                    [patch] app_sms doesn't answer the call, currently
requires Answer() before hand
Description: 
In app_sms.c sms_exec there is code that answers the channel if it's not
already answered. But when sms is invoked with option 'a', the channel may
not have been answered with Answer() app.

the code I believe is answering too late:
      if (chan->_state != AST_STATE_UP)
              ast_answer(chan);

needs to be before:
        if (ast_test_flag(&flags, OPTION_ANSWER)) {
                h.framenumber = 1;           /* Proto 2 */
        .......
 
====================================================================== 

---------------------------------------------------------------------- 
 (0093673) alecdavis (reporter) - 2008-10-15 02:00
 http://bugs.digium.com/view.php?id=13675#c93673 
---------------------------------------------------------------------- 
please remove app_sms.bug13675.diff.txt as this was for trunk version
147592

When applied to 148985 it copies the required code to where it should be,
but doesn't remove the old code, although it doesn't harm it. 

uploaded revised app_sms.bug13675.148985.diff.txt for trunk version
148985

Alec 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-15 02:00 alecdavis      Note Added: 0093673                          
======================================================================