[asterisk-bugs] [Asterisk 0013605]: [patch] Compile error with IMAP_STORAGE due to removed autoconfig.h in Makefile

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13605 
====================================================================== 
Reported By:                tomo1657
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13605
Category:                   Applications/app_voicemail/IMAP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 146007 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-02 15:56 CDT
Last Modified:              2008-10-09 19:31 CDT
====================================================================== 
Summary:                    [patch] Compile error with IMAP_STORAGE due to
removed autoconfig.h in Makefile
Description: 
The removal of autoconfig.h in the Makefile at revision 144993 prevents
app_voicemail.c from compiling with the IMAP_STORAGE flag. 

Optimally we would want to #include "asterisk.h" before the IMAP includes,
but as the comments show, this creates other compile issues involving the
logger.

The quick solution seems to be to keep "asterisk.h" after the IMAP
includes, but additionally include "asterisk/autoconfig.h above the other
includes when IMAP_STORAGE flag is enabled.

#ifdef IMAP_STORAGE
#include "asterisk/autoconfig.h"    // <-- include autoconfig.h line
http://bugs.digium.com/view.php?id=72
#include <ctype.h>
#include <signal.h>
...

I've attached a patch for this but there may be a more elegant solution.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0013604 error: ‘PTHREAD_MUTEX_RECURSIVE’ un...
====================================================================== 

---------------------------------------------------------------------- 
 (0093442) svnbot (reporter) - 2008-10-09 19:31
 http://bugs.digium.com/view.php?id=13605#c93442 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 148200

U   trunk/apps/app_voicemail.c
U   trunk/include/asterisk.h
U   trunk/main/cryptostub.c
U   trunk/main/tdd.c
U   trunk/res/res_config_sqlite.c

------------------------------------------------------------------------
r148200 | seanbright | 2008-10-09 19:31:55 -0500 (Thu, 09 Oct 2008) | 12
lines

Don't include logger.h in asterisk.h by default as it is causing problems
building
app_voicemail.  Instead, include it where it is needed.  This turned out
to be a
relatively minor issue because other headers include logger.h as well.

Need to test -addons before merging this back to 1.6.0.

(closes issue http://bugs.digium.com/view.php?id=13605)
Reported by: tomo1657
Patches: 
      13605_seanbright.diff uploaded by seanbright (license 71)
Tested by: mmichelson

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=148200 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-09 19:31 svnbot         Checkin                                      
2008-10-09 19:31 svnbot         Note Added: 0093442                          
======================================================================