[asterisk-bugs] [Asterisk 0013643]: [patch] VM_CALLERID yields different results if CID is null or empty

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13643 
====================================================================== 
Reported By:                tomo1657
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   13643
Category:                   Core/PBX
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 147263 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-07 15:35 CDT
Last Modified:              2008-10-09 14:28 CDT
====================================================================== 
Summary:                    [patch] VM_CALLERID yields different results if CID
is null or empty
Description: 
Thanks Corydon76 for the patch, but although VM_CIDNAME and VM_CIDNUM have
been dealt with VM_CALLERID still yields different results depending on if
callerid is NULL or empty string.

Perhaps modifying ast_callerid_merge() to treat both NULL and empty string
caller ID the same way is the solution?

I've attached a patch for this where ast_callerid_merge() uses
!ast_strlen_zero() to check for string length for name and num.



====================================================================== 

---------------------------------------------------------------------- 
 (0093419) svnbot (reporter) - 2008-10-09 14:28
 http://bugs.digium.com/view.php?id=13643#c93419 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 147997

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r147997 | tilghman | 2008-10-09 14:28:14 -0500 (Thu, 09 Oct 2008) | 4
lines

When blank, callerid name and number should display "unknown caller" in
voicemail
emails.
(Closes issue http://bugs.digium.com/view.php?id=13643)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=147997 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-09 14:28 svnbot         Checkin                                      
2008-10-09 14:28 svnbot         Note Added: 0093419                          
======================================================================