[asterisk-bugs] [Asterisk 0013643]: [patch] VM_CALLERID yields different results if CID is null or empty

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13643 
====================================================================== 
Reported By:                tomo1657
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13643
Category:                   Core/PBX
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 147263 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-07 15:35 CDT
Last Modified:              2008-10-09 13:06 CDT
====================================================================== 
Summary:                    [patch] VM_CALLERID yields different results if CID
is null or empty
Description: 
Thanks Corydon76 for the patch, but although VM_CIDNAME and VM_CIDNUM have
been dealt with VM_CALLERID still yields different results depending on if
callerid is NULL or empty string.

Perhaps modifying ast_callerid_merge() to treat both NULL and empty string
caller ID the same way is the solution?

I've attached a patch for this where ast_callerid_merge() uses
!ast_strlen_zero() to check for string length for name and num.



====================================================================== 

---------------------------------------------------------------------- 
 (0093414) tomo1657 (reporter) - 2008-10-09 13:06
 http://bugs.digium.com/view.php?id=13643#c93414 
---------------------------------------------------------------------- 
The other suggestion was to make sure that NULL is passed into make_email
file() instead of enc_cidname if cidname is NULL.  A suggestion patch for
that is attached in issue 0013486 . 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-09 13:06 tomo1657       Note Added: 0093414                          
======================================================================