[asterisk-bugs] [Asterisk 0013597]: clid will only set number not name

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13597 
====================================================================== 
Reported By:                john8675309
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   13597
Category:                   CDR/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 145479 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-01 20:56 CDT
Last Modified:              2008-10-08 15:48 CDT
====================================================================== 
Summary:                    clid will only set number not name
Description: 
After upgrading to 1.4 svn CLID will no long hold the name and the number
just the number.  Here is my dialplan.

exten => 7124320002,1,answer
exten => 7124320002,2,set(CALLERID(all)="John" <999>)
exten => 7124320002,3,wait(7200)

core show channels information
  CDR Variables:
level 1: clid=999
level 1: src=999
level 1: dst=700
level 1: dcontext=default
level 1: channel=SIP/192.168.1.1-007a59d0
level 1: lastapp=Wait
level 1: lastdata=7200
level 1: start=2008-10-01 21:04:36
level 1: answer=2008-10-01 21:04:36
level 1: duration=0
level 1: billsec=0
level 1: disposition=ANSWERED
level 1: amaflags=DOCUMENTATION
level 1: uniqueid=1222913076.8

this worked in 1.4.21 just fine
====================================================================== 

---------------------------------------------------------------------- 
 (0093385) murf (administrator) - 2008-10-08 15:48
 http://bugs.digium.com/view.php?id=13597#c93385 
---------------------------------------------------------------------- 
OK, took some time and researched this. The cause is when I introduced the
CDR4/5/6 changes into 1.4, in svn ver 127663, I removed a call to
ast_cdr_setcid() from ast_set_callerid().

Normally, one would think that having ast_set_callerid also set the cdr's
CID info would be an excellent idea. But, ast_set_callerid is called from a
lot of places at a lot of different times, and it made xfers work better to
remove it.

So, the fix will most likely be moving the call to set the CDR info to
more
specific places, like in func_callerid itself. I'll test this theory out. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-08 15:48 murf           Note Added: 0093385                          
======================================================================