[asterisk-bugs] [Asterisk 0013340]: [patch] handle_getvariable doesn't initialize workspace

Asterisk Bug Tracker noreply at bugs.digium.com
Mon Oct 6 15:41:56 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13340 
====================================================================== 
Reported By:                kryptolus
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   13340
Category:                   Resources/res_agi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.21.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-19 08:17 CDT
Last Modified:              2008-10-06 15:41 CDT
====================================================================== 
Summary:                    [patch] handle_getvariable doesn't initialize
workspace
Description: 
Some functions return 0 but don't put anything in the workspace, in which
case handle_getvariable will return the data in the uninitialized buffer
back to the client.
====================================================================== 

---------------------------------------------------------------------- 
 (0093251) svnbot (reporter) - 2008-10-06 15:41
 http://bugs.digium.com/view.php?id=13340#c93251 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 146799

U   branches/1.4/apps/app_speech_utils.c
U   branches/1.4/channels/chan_iax2.c
U   branches/1.4/channels/chan_sip.c
U   branches/1.4/funcs/func_callerid.c
U   branches/1.4/funcs/func_cdr.c
U   branches/1.4/funcs/func_curl.c
U   branches/1.4/funcs/func_groupcount.c
U   branches/1.4/funcs/func_math.c
U   branches/1.4/funcs/func_odbc.c
U   branches/1.4/funcs/func_timeout.c
U   branches/1.4/res/res_smdi.c

------------------------------------------------------------------------
r146799 | tilghman | 2008-10-06 15:41:55 -0500 (Mon, 06 Oct 2008) | 8
lines

Dialplan functions should not actually return 0, unless they have modified
the
workspace.  To signal an error (and no change to the workspace), -1 should
be
returned instead.
(closes issue http://bugs.digium.com/view.php?id=13340)
 Reported by: kryptolus
 Patches: 
       20080827__bug13340__2.diff.txt uploaded by Corydon76 (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=146799 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-06 15:41 svnbot         Checkin                                      
2008-10-06 15:41 svnbot         Note Added: 0093251                          
======================================================================




More information about the asterisk-bugs mailing list