[asterisk-bugs] [Asterisk 0013330]: [patch] DISA does not accept extensions beginning with "#"

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13330 
====================================================================== 
Reported By:                jcovert
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   13330
Category:                   Applications/app_disa
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.21.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 won't fix
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-08-17 22:44 CDT
Last Modified:              2008-11-28 12:44 CST
====================================================================== 
Summary:                    [patch] DISA does not accept extensions beginning
with "#"
Description: 
As those familiar with central office and PBX dialplans in North America
know, while "#" is often used as a terminator for variable length numbers,
it has always also been accepted as an initial character.

When I recently (finally, now that Mac OS X seems to work with the latest
patches) upgraded my production PBX to 1.4, I discovered that I was unable
to dial extensions in a DISA's context which had the pattern "_#XX"

To correct this, in the check for an extension terminated by '#' (line 301
of app_disa.c), I now also check for "i>0", so that the test only succeeds
and breaks out of the loop if the '#' is not the first character.

To comply with industry standards and practice, I suggest and request this
patch become a permanent part of Asterisk.
====================================================================== 

---------------------------------------------------------------------- 
 (0095597) jcovert (reporter) - 2008-11-28 12:44
 http://bugs.digium.com/view.php?id=13330#c95597 
---------------------------------------------------------------------- 
I'm reopening this because this has really broken existing applications.

>I'm not really happy with changing how this delimiter works.

This only changes the behaviour if "#" is entered as the first character
when connected to a DISA.  Previously, this worked correctly and allowed
the DISA's dialplan to contain entries with a "#" at the beginning, or even
a single "#", which would terminate immediately, as now, but going to that
extension, rather than to "i", which is the only place a single "#" can go
to now, since a null extension is meaningless.

>it's pretty easy to work around this using dialplan

Not with a DISA.  The change that created this bug made it necessary to
either (a) locally implement my simple change or (b) not use a DISA at all,
and just create an IVR with Dialtone recorded in a file for Background.

Please reconsider this simple patch, restoring prior behaviour, which
complied with typical industry numbering plans, which allowed "#" as an
initial character, only treating it as a terminator later. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-28 12:44 jcovert        Note Added: 0095597                          
======================================================================