[asterisk-bugs] [Asterisk 0013952]: [patch] Add packet information to debug

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13952 
====================================================================== 
Reported By:                wedhorn
Assigned To:                mvanbaak
====================================================================== 
Project:                    Asterisk
Issue ID:                   13952
Category:                   Channels/chan_skinny/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 158753 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-11-22 14:38 CST
Last Modified:              2008-11-24 16:23 CST
====================================================================== 
Summary:                    [patch] Add packet information to debug
Description: 
Adds "packet" option to "skinny set debug" which results in skinny packet
types and destination/source being displayed on the CLI. Has been very
helpful for debugging.
====================================================================== 

---------------------------------------------------------------------- 
 (0095437) wedhorn (reporter) - 2008-11-24 16:23
 http://bugs.digium.com/view.php?id=13952#c95437 
---------------------------------------------------------------------- 
I'll test it when I get home but in the meantime a couple of comments.

At about line 2020 there's an issue regarding logging the packets. If
SKINNY_PACKETDEBUG is not set, skinnydebug can't be greater than 1 and so
the logging will never occur. Do we even need this logging?

There's some stuff at about line 5200 (us and ourip) that shouldn't be
part of that patch (leftovers from the axe patch).

Rather than SKINNY_PACKETDEBUG, it may be more sensible to change it to
SKINNY_DEVMODE or similar so we can add further dev type stuff. I've
partially written a bit of code to craft and transmit a packet on the fly
which is helpful for protocol work. Again, this wouldn't be something you
would want to inflict on users. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-24 16:23 wedhorn        Note Added: 0095437                          
======================================================================