[asterisk-bugs] [Asterisk 0012269]: [branch] Deadlock after Originate from AMI to Agent

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12269 
====================================================================== 
Reported By:                IgorG
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   12269
Category:                   Channels/chan_agent
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 110444 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-03-21 03:15 CDT
Last Modified:              2008-11-24 15:36 CST
====================================================================== 
Summary:                    [branch] Deadlock after Originate from AMI to Agent
Description: 
I have discovered deadlock while using chan_agent and originate cal via
AMI. To reproduce need one agent and one registered phone. 

1) Login via AMI and make originate call
2) Answer a call both sides, talk and hangup phone.
3) After hangup MoH for agent doesn't starts and CLI show ERRORs:

    -- Started music on hold, class 'default', on SIP/104-08362618
[Mar 21 13:35:21] ERROR[8145]:
/usr/src/voip/asterisk-trunk/asterisk-trunk.patched-cng/include/aster:461
__ast_pthread_mutex_unlock: chan_agent.c line 843 (agent_hangup): attempted
unlock mutex '&p->app_lock' without owning it!
[Mar 21 13:35:21] ERROR[8145]:
/usr/src/voip/asterisk-trunk/asterisk-trunk.patched-cng/include/aster:463
__ast_pthread_mutex_unlock: chan_agent.c line 979 (agent_new):
'&p->app_lock' was locked here.
[Mar 21 13:35:21] ERROR[8145]:
/usr/src/voip/asterisk-trunk/asterisk-trunk.patched-cng/include/aster:486
__ast_pthread_mutex_unlock: chan_agent.c line 843 (agent_hangup): Error
releasing mutex: Operation not permitted

3) 'agent show online' still show called side in list

server-voip*CLI> agent show online
1001         (Vasya Pupkin) logged in on SIP/104-08362618 is idle
(musiconhold is 'default')
1 agents online>

3) After second try to Originage, originate fail and using CLI command
'agent show online' fail and make CLI frozen
====================================================================== 

---------------------------------------------------------------------- 
 (0095423) jpeeler (administrator) - 2008-11-24 15:36
 http://bugs.digium.com/view.php?id=12269#c95423 
---------------------------------------------------------------------- 
I'm waiting for the code to be reviewed as the changes are substantial,
despite the small amount of code changed. The device state issues though
should have been reported in another bug. Somebody else may have reported
it by now. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-24 15:36 jpeeler        Note Added: 0095423                          
======================================================================